feat!: Use StorageService to store source code
#3777
Draft
+980
−263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Mrtenz
reviewed
Dec 16, 2025
GuillaumeRx
force-pushed
the
gr/storage-service
branch
from
57095fe to
6a20e47
Compare
GuillaumeRx
force-pushed
the
gr/storage-service
branch
from
202b635 to
801cc12
Compare
GuillaumeRx
force-pushed
the
gr/storage-service
branch
from
655f32e to
85b792f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3777 +/- ##
=======================================
Coverage 98.33% 98.33%
=======================================
Files 422 422
Lines 12082 12106 +24
Branches 1876 1876
=======================================
+ Hits 11881 11905 +24
Misses 201 201 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the use of
StorageServiceto store the Snap source codes. Due to this storage being async, theSnapControllerinitialization is now async and the preinstalled snaps setup now lives ininit()